search

seomoz / qless-core

Core Lua Scripts for qless
MIT License
85 stars 33 forks source link

Lua Script Error on Redis 3.2 #63

Open icheishvili opened 8 years ago

icheishvili commented 8 years ago

On Redis 3.2, this error breaks qless:

Redis::CommandError - ERR Error running script (call to f_3f9682e7ddb462dca8c60a26d5e88ac70c3a49e9): @user_script:925: @user_script: 925: Lua redis() command arguments must be strings or integers :
  redis (3.3.0) lib/redis/client.rb:121:in `call'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/instrumentation/redis.rb:42:in `block in call'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/datastores.rb:111:in `block in wrap'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/method_tracer.rb:73:in `block in trace_execution_scoped'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/method_tracer_helpers.rb:82:in `trace_execution_scoped'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/method_tracer.rb:71:in `trace_execution_scoped'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/datastores.rb:108:in `wrap'
  newrelic_rpm (3.15.1.316) lib/new_relic/agent/instrumentation/redis.rb:41:in `call'
  redis (3.3.0) lib/redis.rb:2394:in `block in _eval'
  redis (3.3.0) lib/redis.rb:58:in `block in synchronize'
  /Users/xxx/.rbenv/versions/2.2.3/lib/ruby/2.2.0/monitor.rb:211:in `mon_synchronize'
  redis (3.3.0) lib/redis.rb:58:in `synchronize'
  redis (3.3.0) lib/redis.rb:2393:in `_eval'
  redis (3.3.0) lib/redis.rb:2445:in `evalsha'
   () Users/xxx/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/qless-e5615c39eaff/lib/qless/lua_script.rb:44:in `_call'
   () Users/xxx/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/qless-e5615c39eaff/lib/qless/lua_script.rb:26:in `block in call'
   () Users/xxx/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/qless-e5615c39eaff/lib/qless/lua_script.rb:49:in `handle_no_script_error'
   () Users/xxx/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/qless-e5615c39eaff/lib/qless/lua_script.rb:25:in `call'
   () Users/xxx/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/qless-e5615c39eaff/lib/qless.rb:202:in `call'
   () Users/xxx/.rbenv/versions/2.2.3/lib/ruby/gems/2.2.0/bundler/gems/qless-e5615c39eaff/lib/qless/queue.rb:108:in `put'
evanbattaglia commented 5 years ago

As per https://github.com/seomoz/qless-core/pull/64, I believe this is fixed (fixes the issue I had with it anyway) and can be closed, anyone disagree?