search

seomoz / qless-core

Core Lua Scripts for qless
MIT License
85 stars 34 forks source link

Heartbeat Worker Registration #81

Closed dlecocq closed 6 years ago

dlecocq commented 6 years ago

Qless keeps a list of active workers, but until now, heartbeating a running job was not sufficient to keep a worker listed as in the active pool.

We keep the max-worker-age configured to be relatively low (10 minutes) so that we can be made aware quickly when workers disappear. However, if a worker is saturated with jobs that take longer than that interval but are being heartbeated regularly, that presents a false impression of the number of active workers.

@b4hand @evanbattaglia @benkirzhner @kq2

dlecocq commented 6 years ago

Thanks for looking this over! I don't have merge powers here, but once this is merged I can get a PR out for qless-js as well to pull this in