Save job data as-is without re-encoding

seomoz / qless-core

Core Lua Scripts for qless

MIT License

85 stars 33 forks source link

Save job data as-is without re-encoding #83

Open NathanBaulch opened 5 years ago

NathanBaulch commented 5 years ago

cjson escapes forward slashes which is causing problems for me. I'd like qless to just save job data to Redis verbatim without any decode/encode side-effects. I've also fixed some inconsistencies with job data param names and assertion messages. All unit tests are passing.

dlecocq commented 5 years ago

I don't see the checks run on this PR, but the content looks good to me

NathanBaulch commented 5 years ago

Any idea why Travis didn't kick off?

dlecocq commented 5 years ago

I don't :-/ I no longer have access to the Travis configuration. @lindseyreno or @evanbattaglia - do you happen to know?

lindseyreno commented 5 years ago

I don't know how or why but the repo was deactivated in Travis. I reactivated it and it is working again. Either reopen the PR or push an empty commit to trigger a build.

dlecocq commented 5 years ago

LGTM

NathanBaulch commented 5 years ago

Bump!

NathanBaulch commented 2 years ago

Bump!

b4hand commented 2 years ago

See my comment on #85 regarding the state of this project.