search

seomoz / qless-core

Core Lua Scripts for qless
MIT License
85 stars 34 forks source link

Support waiting job pagination #85

Open NathanBaulch opened 5 years ago

NathanBaulch commented 5 years ago

I have a scenario where I need to iterate through all waiting jobs in a queue so I can cancel them, but was surprised to find this feature missing. This simple PR adds support for the "waiting" status in the existing pageable jobs API.

Unit test included of course.

dlecocq commented 5 years ago

Looks good to me, though I lack merge powers.

NathanBaulch commented 2 years ago

Bump!

b4hand commented 2 years ago

@NathanBaulch Unfortunately, I think all of the folks who formerly worked on qless at Moz (seomoz GitHub org) no longer work there, and it seems like the company has revoked permissions for non-employees that were working on the various open source projects. I've tried to contact various employees that are still at the company but none seem interested or able to grant permissions externally. So I would consider these projects to be abandoned. If someone wants to revive qless, I imagine you'll need to start a separate fork, and probably not using the GitHub fork mechanism as that will force PRs to be merged into this upstream repo which is a dead end at this point in time. I too have tried merging PRs, but can no longer do so.

NathanBaulch commented 2 years ago

Ah, shame. Thanks for the inside info @b4hand !

UncleMatty commented 2 years ago

Worth noting that for those of us who were at Moz from 2018-2020, qless had become a bit of an anti pattern anyway.

If you really need help with this, I might be able to track someone down.

NathanBaulch commented 2 years ago

Interesting... qless was being abused somehow? Or requirements/scale grew beyond it's capabilities? Any nuggets of wisdom to share from the trenches @UncleMatty?

UncleMatty commented 2 years ago

Nothing particularly insightful. Using qless to manage a job queue may have been creative and clever at one point, but it outgrew its usefulness, particularly with the emergence of lighter weight and easier to manage tools like Kafka, etc.