seomoz / qless

Queue / Pipeline Management
MIT License
294 stars 76 forks source link

introduce explicit factor to exponent backoff strategy #220

Closed vadim-ex closed 9 years ago

myronmarston commented 9 years ago

Looks good besides the mutation concern.

myronmarston commented 9 years ago

One other thought: if you dislike the interface of the exponential method that is forced upon you by backwards compatibility concerns, you could just create a new method, such as exponential_with_factor or exponential_with_base or whatever and make that method have whatever argument interface you want. Then exponential can be left alone.

I have no preference for which direction you take (changing exponential or defining a new method) but thought I'd mention it as an option since you expressed a dislike for the interface.

vadim-ex commented 9 years ago

Thank you. In this particular case duplicating method is not an option. The purpose of breaking compatibility is to force change of bad code, and an additional method would defeat it.

vadim-ex commented 9 years ago

PTAL

vadim-ex commented 9 years ago

PTAL

myronmarston commented 9 years ago

LGTM