seomoz / qless

Queue / Pipeline Management
MIT License
294 stars 76 forks source link

Correctly declare thin dependency in gemspec file #243

Closed neilmb closed 8 years ago

neilmb commented 8 years ago

thin is a required dependency for qless-web. It should be declared as a dependency in the .gemspec (which will then be included in the Gemfile) so that the dependency is picked up even when not installed with bundler.

@dlecocq

@a1ph4g33k @myronmarston: can you confirm this is good Ruby practice?

myronmarston commented 8 years ago

LGTM