search

seomoz / qless

Queue / Pipeline Management
MIT License
294 stars 76 forks source link

Rename "failures" to "failed" in qless-stats #275

Closed dlecocq closed 6 years ago

dlecocq commented 6 years ago

Graphite/whisper cannot have a name that serves both as a metric name and as a dot-delimited prefix to another metric. Because individual failure types are reported as "failures.", the "failures" metric fails to be reported if ever there has been a report of "failures.". While this tool is not specific to graphite, it is a common tool in the monitoring ecosystem and it takes little effort to make this tool compatible.

@b4hand @evanbattaglia @kq2

dlecocq commented 6 years ago

I think it'd be a good idea to do at least one of those.

On the version, I have two minds about it -- it doesn't really change the core functionality, but I'd hate for peoples' alerts to break all of a sudden. I guess now that I say it aloud, probably deserves a 0.12.0 bump.

I'll add a section on release notes.

dlecocq commented 6 years ago

@b4hand -- updated

dlecocq commented 6 years ago

Build finally passed (there was one flaky build, and then Travis was being slow). Should be good to go to hit the merge button, @b4hand