search

seomoz / reppy

Modern robots.txt Parser for Python
MIT License
187 stars 40 forks source link

Fix sitemaps api #114

Open wumpus opened 5 years ago

wumpus commented 5 years ago

in py2, robot.sitemaps returns a list. in py3 it returns whatever comes out of map which is some kind of iter.

this pr changes it to always return a list.

Fixes #109

dlecocq commented 5 years ago

The change looks good, but I'm not sure why the submodule got updated? Was it out of date?

wumpus commented 5 years ago

I know nothing about submodules.

dlecocq commented 5 years ago

I can push a branch preserving your commits, but resolving the submodule issue. Otherwise, you could give this a shot:

# Ensure all the submodules are initialized and checked out at the current SHAs
git submodule update --init --recursive
(
  cd reppy/rep-cpp
  git pull --rebase origin master
  # Update the googletest submodule
  git submodule update --init --recursive
)

git add reppy
git commit --amend

And thanks for the PR, btw!

wumpus commented 5 years ago

Hm, that left me with a repo that can't push -- not really worth debugging, though.