search

seomoz / shovel

Rake, for Python
MIT License
660 stars 49 forks source link

stop `shovel tasks` from choking in docstring newlines #31

Open philadams-zz opened 10 years ago

dlecocq commented 10 years ago

Looks good to me, though you'll have to fix the failing test, and it would be nice to add a test that explicitly tests this case.

philadams-zz commented 10 years ago

Can do... the test that fails (when I run make test) is an ImportError for test_run.py: from path import path. Is that os.path?

I'm testing with the makefile, having run a `python setup.py develop' - is this not the right way to go?

Oh, and once I've made the changes / added a test, do I close this pull request and open a new one? What's the recommended way of updating my pull request?

dlecocq commented 10 years ago

Ah, that's path.py. I'm working on getting a saner setup.py -- will keep you posted.

philadams-zz commented 10 years ago

Sounds good - I'll work on the test and then wait to hear about that path import.

dlecocq commented 10 years ago

I just pushed a change to master that details how to get these tests running. Now you can:

python setup.py nosetests`

That installs all the requisite packages and then runs the tests.