search

seomoz / url-cpp

C++ bindings for url parsing and sanitization
MIT License
19 stars 11 forks source link

Expose setters #17

Closed dlecocq closed 8 years ago

dlecocq commented 8 years ago

url-py has a filter_params which takes a predicate to determine whether a query or param should be filtered. But we can't pass a python predicate down to url-cpp (at least without quite some gymnastics), so one way out is to provide a setter for query and params.

@b4hand @tammybailey @tanglyh @martin-seomoz

dlecocq commented 8 years ago

@b4hand -- switched to set* for the setters.

b4hand commented 8 years ago

LGTM