seomoz / url-cpp

C++ bindings for url parsing and sanitization
MIT License
19 stars 11 forks source link

BIG-3640 - Tel Protocol #31

Closed dlecocq closed 7 years ago

dlecocq commented 7 years ago

This is a long-standing bug, but not one that has impacted us very much.

Bear in mind that this is a C++ port of the interpretation given in the original url-py, which historically relied on urlparse. This is especially true when considering the parsing of URLs. This particular part of the original parsing uses the rule: if we find a :, and there's either nothing after it or at least one non-digit, the scheme is the part before the :.

To be as minimally disruptive as possible, this just adds support for a category of known schemes that override that determination. For instance, links like tel:12345 were obviously failing that test.

@lindseyreno @b4hand @tammybailey