seongjaelee / nvatom

nvatom (unpublished from atom.io)
MIT License
75 stars 14 forks source link

No search results when note directory contains spaces #31

Open 0thernet opened 9 years ago

0thernet commented 9 years ago

I migrated from notational-velocity to nvatom after finding that alt-cmd-l no longer brought up the search bar. I've set my notes directory, but don't see any results when typing in the search bar. Oddly, if I type the name of a file and hit enter, the file opens.

I'm on 0.8.1 (44).

:trophy: for working on this package – notational velocity with vim mode, all in the same text editor I use to code, is a killer combo

seongjaelee commented 9 years ago

Hmm, I still have no idea what is going on for your case. But could you go to nvatom settings and turn off "Enable Lunr Pipeline" boolean setting and let me know if it is fixed or not? We recently changed the search engine to lunr and it ignores some of the stop words (such as "an" or "be") during the search.

=) I am so happy many people loves notational velocity (not just this atom package, but the concept in general).

0thernet commented 9 years ago

It looks like this issue only happens when the Note directory contains spaces. (This wasn't an issue in the notational-velocity package).

My notes directory is /Users/bg/Dropbox (Stripe)/Notes. Same issue when escaping the spaces: /Users/bg/Dropbox\ \(Stripe\)/Notes.

For now, I've moved my notes directory, but it would be nice to see a fix for this. (Renaming my dropbox folder is non-trivial, since the Dropbox app chooses the name, so my notes are currently unsynced with Dropbox).

jonmagic commented 9 years ago

Looks like it is a bug in my docquery library (that nvatom uses for search):

~/Projects/gfm-lists (master)🐑 💨 ✨  npm install docquery --global

> fsevents@0.3.8 install /opt/nodes/0.12.7/lib/node_modules/docquery/node_modules/chokidar/node_modules/fsevents
> node-gyp rebuild

  SOLINK_MODULE(target) Release/.node
  CXX(target) Release/obj.target/fse/fsevents.o
  SOLINK_MODULE(target) Release/fse.node
/opt/nodes/0.12.7/bin/dq -> /opt/nodes/0.12.7/lib/node_modules/docquery/lib/cli.js
docquery@1.1.0 /opt/nodes/0.12.7/lib/node_modules/docquery
├── minimist@1.2.0
├── underscore@1.8.3
├── tilde-expansion@0.0.0 (etc-passwd@0.0.1)
├── lunr@0.5.12
└── chokidar@1.0.6 (arrify@1.0.0, path-is-absolute@1.0.0, is-glob@1.1.3, async-each@0.1.6, is-binary-path@1.0.1, glob-parent@1.3.0, readdirp@1.4.0, anymatch@1.3.0, fsevents@0.3.8)
~/Projects/gfm-lists (master)🐑 💨 ✨  dq
^C
~/Projects/gfm-lists (master)🐑 💨 ✨  cd ~/
~ 🐑 💨 ✨  open .
~ 🐑 💨 ✨  dq -h
Usage: dq [options] query

Options:
  -p, --path <path>    Path to search
  -r, --recursive      Search sub directories
  -b, --body           Include document body in search result
  -h, --help           Show dq help
~ 🐑 💨 ✨  dq -p ~/Foo\ \(Bar\)/aaa/ note
[]
~ 🐑 💨 ✨  dq -p ~/Foo\ \(Bar\)/aaa/ food
[]
~ 🐑 💨 ✨  dq -p "~/Foo\ (Bar)/aaa/" food
[]
~ 🐑 💨 ✨  dq -p "/Users/jonmagic/Foo\ (Bar)/aaa/" food
[]
~ 🐑 💨 ✨  cd Foo\ \(Bar\)/
~/Foo (Bar) 🐑 💨 ✨  dq -p aaa food
[
  {
    "filePath": "aaa/where is the food.md",
    "fileName": "where is the food.md",
    "title": "where is the food",
    "modifiedAt": "2015-02-14T00:16:24.000Z"
  },
  {
    "filePath": "aaa/bar food!.md",
    "fileName": "bar food!.md",
    "title": "bar food!",
    "modifiedAt": "2015-03-13T18:06:51.000Z"
  }
]

I'm going to try and look into it now but I might not have a fix for a few days, life is a bit hectic. Pull requests are welcome of course :) https://github.com/jonmagic/docquery

mo-tom commented 9 years ago

Same for me if path contains square brackets [ ]

jessejanderson commented 8 years ago

Any chance this is getting fixed?