WIP: New document search

jonmagic commented 8 years ago

WARNING: This is very busted do not merge :exclamation:

I'm long overdue to get something out for https://github.com/seongjaelee/nvatom/issues/35... I started with great intentions but life got the best of me :/ Also an apology up front, I did everything in javascript, mostly so I could take advantage of ES6 features and because I find no joy writing coffeescript. I realize the rest of nvatom is in coffeescript and having a mix of the two probably isn't best, but I wasn't getting any momentum with coffeescript so I had to try ES6 for my own sanity.

I started out by trying to implement each component separately. I should have known better, shame on me :grin:

Eventually I came back to my senses and started at the existing NotationalVelocityView and worked my way down into the Documents model. It kinda sucks in its current state tbh, but I figured getting something out for folks to see was better than continuing to procrastinate.

[x] Remove dependency on docquery
[x] Use search-index instead of lunr.js
[x] Search function for full-text document searches
[x] Recent function for getting a list of recently updated documents
[ ] Profile and tune memory usage (tweaking search-index where possible)
[ ] Intelligently remove documents from search index that no longer exist in your Notes folder (was thinking about hooking into the search function to filter out dead documents from search results and update the index at the same time)
[ ] Benchmark performance and then improve it
[ ] Fix all of the other bugs I haven't found yet :grin:

So yeah, this is in a pretty rough state, but maybe some folks will enjoy reading it? I'm about to head on holiday for a few weeks so I won't be pushing this forward until mid to late November. Feel free to pick parts of it, all of it, or ditch the entire thing :)

ghost commented 8 years ago

:+1: Thanks for your work on this. Looking forward to seeing progress over the coming months. :trophy:

jonmagic commented 8 years ago

Imma close this as I just haven't had time to work on it.

ghost commented 8 years ago

I don't blame you. For what it's worth I've been working on a way to duplicate nvatom functionality with a mixture of native Atom, atom-fuzzy-grep and one or two other plugins. Most of the basic building blocks are already part of Atom.

seongjaelee / nvatom

WIP: New document search #41