search

seongjaelee / nvatom

nvatom (unpublished from atom.io)
MIT License
75 stars 14 forks source link

Argument to path.extname must be a string. #64

Closed lexicalunit closed 7 years ago

lexicalunit commented 7 years ago

Resolves #62.

lexicalunit commented 7 years ago

@seongjaelee I also fixed a broken spec test in this PR. It seems from the spec test that nvatom used to issue a notification when the default directory was set to the directory under packages directory. However, what it now does is throw an error which causes the active package promise to be unfulfilled. I used chai-as-promised to properly verify the promise fails under this condition.