seongminp / hyperseg

Code for HyperSeg and HyperSum
12 stars 0 forks source link

i found some bug in you code. #1

Open JackJessada opened 3 months ago

JackJessada commented 3 months ago

embedder.py line 116

embeddings.append(embedding.numpy))

it shoud be

embeddings.append((embedding.numpy))

and in hypersum.py

line 27 - 28

embeddings, sentence_index = self.embedder.embed(sentences)
distances = pairwise_distances(embeddings, metric="cosine")

it error float() argument must be a string or a real number, not 'builtin_function_or_method' because

embeddings, sentence_index = self.embedder.embed(sentences)

embeddings is a list of numpy.

but

pairwise_distances(embeddings, metric="cosine")

require real number or string

seongminp commented 3 months ago

Line 116 in embedder.py should be embeddings.append(embedding.numpy())

Also there is a suspicious trailing ( at the end of embedder.py. Probably some shenanigans during copy paste.