Open gklezd opened 3 months ago
I am trying to use HyperSegSegmenter.segment() on the ICSI corpus.
I noticed that the threshold T is set at T = μ - σ
Then in the local minima computation
https://github.com/seongminp/hyperseg/blob/7c311020123e762dc51c9f096834aab3a056e809/hyperseg.py#L14
the condition includes array[i] > threshold
array[i] > threshold
Shouldn't it be the other way round (array[i] < threshold) since we want the similarity to be below the threshold?
array[i] < threshold
Thanks!
I think you're correct. At some point i changed the code from "distances" to "similarities" and forgot to flip the signs.
I am trying to use HyperSegSegmenter.segment() on the ICSI corpus.
I noticed that the threshold T is set at T = μ - σ
Then in the local minima computation
https://github.com/seongminp/hyperseg/blob/7c311020123e762dc51c9f096834aab3a056e809/hyperseg.py#L14
the condition includes
array[i] > threshold
Shouldn't it be the other way round (
array[i] < threshold
) since we want the similarity to be below the threshold?Thanks!