search

seothemes / genesis-starter-theme

A starter theme for the Genesis Framework with a modern development workflow
https://demo.seothemes.com/genesis-starter
145 stars 39 forks source link

Genesis Theme Claim breaks webpack config file #34

Open claytoncollie opened 4 years ago

claytoncollie commented 4 years ago

Spinning up a new theme and ran npm run rename successfully.

Then ran npm run build and got an error on this line.

https://github.com/seothemes/genesis-starter-theme/blob/4d24e9f00f6f08cf0c2912281d838acf3fa25760/webpack.mix.js#L132

Looks like the genesis-theme-claim package is doing a global search and replace on the packageJson.version string and maybe this file should get excluded.

seothemes commented 4 years ago

Thanks @claytoncollie, haven't had a chance to test genesis-theme-claim with the new version yet. Will keep this one open until it's fixed.

bisonbrah commented 4 years ago

I noticed this as well: if you comment out like this - https://d.pr/i/HvKgLx it'll fix the error.