search

seoulsky-field / CXRAIL-dev

CXRAIL-dev
MIT License
7 stars 0 forks source link

Features: Append More Options on CXR dataloader #11

Closed juppak closed 1 year ago

juppak commented 1 year ago

What

Why

How

Comment

chrstnkgn commented 1 year ago

Seems to become a large chunk of work to be done! :joy: I just have a small question as I did not fully understand the concept of conditional training.


For the conditional training option, are targets of the uncertain labels assigned while the model is being trained? Or is pretraining needed before we train for the final classifier?

juppak commented 1 year ago

If my understanding is correct,pretraining in some parent data's conditions needed before we train for the final classifier.(i'll check correctly as soon as possible!)

kdg1993 commented 1 year ago

Thanks a lot, @juppak for taking my call for help (#9) seriously and importantly.

I'm very much looking forward to the result. However, due to my lack of knowledge of mine 😭 about label smoothing & conditional training, it might be great to have time together to share what it is one day.

juppak commented 1 year ago

You are right!! 😀 This part must be shared with all together. After check previous papers & code, will share with you guys.
+) many papers are related with this part 🤣 If someone wants to look this part, check these papers.

kdg1993 commented 1 year ago

I am trying to test the conditional train by branch feature/#11 but encountered an error which is hard to find why 😢

I tried without any change in codes & command in the CLI by python main.py epochs=2 mode=default
 And the occurred error is

Traceback (most recent call last): File "/usr/local/lib/python3.8/site-packages/hydra/_internal/utils.py", line 213, in run_and_report return func() File "/usr/local/lib/python3.8/site-packages/hydra/_internal/utils.py", line 453, in lambda: hydra.run( File "/usr/local/lib/python3.8/site-packages/hydra/_internal/hydra.py", line 105, in run cfg = self.compose_config( File "/usr/local/lib/python3.8/site-packages/hydra/_internal/hydra.py", line 594, in compose_config cfg = self.config_loader.load_configuration( File "/usr/local/lib/python3.8/site-packages/hydra/_internal/config_loader_impl.py", line 141, in load_configuration return self._load_configuration_impl( File "/usr/local/lib/python3.8/site-packages/hydra/_internal/config_loader_impl.py", line 235, in _load_configuration_impl self._process_config_searchpath(config_name, parsed_overrides, caching_repo) File "/usr/local/lib/python3.8/site-packages/hydra/_internal/config_loader_impl.py", line 158, in _process_config_searchpath loaded = repo.load_config(config_path=config_name) File "/usr/local/lib/python3.8/site-packages/hydra/_internal/config_repository.py", line 349, in load_config ret = self.delegate.load_config(config_path=config_path) File "/usr/local/lib/python3.8/site-packages/hydra/_internal/config_repository.py", line 101, in load_config ret.defaults_list = self._create_defaults_list(config_path, raw_defaults) File "/usr/local/lib/python3.8/site-packages/hydra/_internal/config_repository.py", line 236, in _create_defaults_list raise ValueError( ValueError: Unsupported item value in defaults : bool. Supported: string or list

My question is

  1. How can I find the reason for the error? (it is difficult because the error message is based on hydra)
  2. Is it only for me? (I'm not sure if this is because of my specific environment or not)
juppak commented 1 year ago

Oh! Sorry about bad codes... 😭 I'm trying to complete that conditional traning parts. plz wait for me a moment...

kdg1993 commented 1 year ago

Oh, I please not sorry 😭 I am so sorry for bothering you I just wanted to help to make it and thanks for letting me know about the current status! Please let us know when the test code can run! I really look forward to try it 😁

juppak commented 1 year ago

Yes I know your willingness to help! 🤗 I'll share that parts as soon as the test code works. Thank you!