seox123 / pe

0 stars 0 forks source link

Delete all with tag does not handle archived tasks #3

Open seox123 opened 2 years ago

seox123 commented 2 years ago

Description of the bug:

Using the command deleteA deletes only unarchived tasks. When the archived task is later unarchived, and the label is added back to a different task or contact, the number of contacts/tasks associated with the label will also become incorrect.

To reproduce:

Steps:

  1. Add 2 different tasks using addT.
  2. markL both of the tasks with the same label name. Do this by running markL t/2 l/CS2101 and markL t/2 l/CS2101 if the 2 tasks are the only tasks present.
  3. Archive one of the tasks using archiveT 1.
  4. Run deleteA CS2101, or on the label name used in Step 2.
  5. Run listL and notice that the label is no longer displayed.
  6. Run listAT then unarchiveT 1 to unarchive the previously archived task in Step 3.
  7. Add the same label back to the other task using addL.
  8. Notice that the entry in listL displays the wrong association number.

Expected behaviour:

The expected behaviour is that either unarchived tasks are also deleted or the label list should be updated correctly.

Screenshots/Video:


video:https://raw.githubusercontent.com/seox123/pe/main/files/ddd6e75f-1c58-4d8c-b311-ee7f0b7841da.mp4

Justification:

This is a feature that a user will unlikely chance upon, so its severity is Low. However, it can cause inconvenience for the user expecting the label list to be correct.

nus-pe-script commented 2 years ago

Your response not required for this bug as the team has accepted the bug as it is.