search

sepandhaghighi / art

🎨 ASCII art library for Python
https://www.ascii-art.site
MIT License
2.14k stars 130 forks source link

adding colors #242

Closed codewithnick closed 1 year ago

codewithnick commented 1 year ago

Description

Could not find anything related to changing color to print in the terminal, especially for printing ascii letters, if this feature is not available then it would be good to add it?

sepandhaghighi commented 1 year ago

@codewithnick Hi Thanks for your comment 💯 Text coloring in the terminal is a bit hacky! Some interesting libraries like termcolor work on it. So it's not necessary for art to support it directly.

>>> from termcolor import colored, cprint
>>> from art import text2art
>>> cprint(text2art("test"), "red")

@sadrasabouri What do you think?

sadrasabouri commented 1 year ago

@codewithnick Hi Thanks for your comment 💯 Text coloring in the terminal is a bit hacky! Some interesting libraries like termcolor work on it. So it's not necessary for art to support it directly.

>>> from termcolor import colored, cprint
>>> from art import text2art
>>> cprint(text2art("test"), "red")

@sadrasabouri What do you think?

You're right. It's better for packages to be atomic. I prefer art sticks to its main goal.

codewithnick commented 1 year ago

I want to make a contribution to this repository do you have any ideas. I thought this was missing so bought it up.

sadrasabouri commented 1 year ago

@codewithnick you can start working on this issue. Before starting anything please read the contribution guidelines.

PS: For getting an about how you should solve that issue, you may need to take a look at this PR after skimming the source code one. Ask your probable question at the #241 issue tracker and we will respond ASAP.