Closed codewithnick closed 1 year ago
Thanks for your efforts. There are some points you should take into consideration before checking my comments:
- There is no rush. most of my comments were mentioned by @sepandhaghighi in your last PR but were not taken into action.
- You should update
CHANGELOG.md
, too.- You should write tests for your new features.
- You can commit on your branch and this PR will be updated. So no need for closing PR after each review and opening new one.
sorry about the confusion ill send a new pr, can you tell me where should i write the tests , I am confused
No need for new PR @codewithnick
Just commit and push your code to your dev
branch and this PR will be updated.
For tests take a look at here.
Merging #248 (049cb29) into dev (0719521) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## dev #248 +/- ##
=======================================
Coverage 99.84% 99.84%
=======================================
Files 7 7
Lines 1185 1185
Branches 79 79
=======================================
Hits 1183 1183
Misses 1 1
Partials 1 1
Impacted Files | Coverage Δ | |
---|---|---|
art/art.py | 99.29% <100.00%> (ø) |
I will add tests myself after your last commit. @codewithnick
thank you so much guys let me know if can also work on something else
Reference Issues/PRs
241
What does this implement/fix? Explain your changes.
added space parameter in art and aprint functions
Any other comments?