search

sepandhaghighi / art

🎨 ASCII art library for Python
https://www.ascii-art.site
MIT License
2.14k stars 130 forks source link

Modernize code #251

Closed eumiro closed 1 year ago

eumiro commented 1 year ago
  1. Remove useless default encoding for source files (UTF-8 is the default)
  2. Simplify loops and conditions
codecov[bot] commented 1 year ago

Codecov Report

Merging #251 (b24f9ce) into dev (292b5aa) will decrease coverage by 0.00%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #251      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.00%     
==========================================
  Files           7        7              
  Lines        1185     1181       -4     
  Branches       79       80       +1     
==========================================
- Hits         1183     1179       -4     
  Misses          1        1              
  Partials        1        1
Impacted Files Coverage Δ
art/art_param.py 100.00% <ø> (ø)
art/art.py 99.28% <100.00%> (-0.01%) :arrow_down:
eumiro commented 1 year ago

Thank you for the feedback, @sepandhaghighi. Dropped the commit with the coding removal and updated AUTHORS.md. The other commit is a pure refactoring, so it does not really make sense to add it to CHANGELOG.md. It does not change any functionality of the code.