Closed sadrasabouri closed 3 years ago
Merging #44 (4e03f50) into dev (77952c1) will increase coverage by
0.15%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dev #44 +/- ##
==========================================
+ Coverage 95.84% 95.98% +0.15%
==========================================
Files 2 2
Lines 168 174 +6
Branches 18 18
==========================================
+ Hits 161 167 +6
Misses 4 4
Partials 3 3
Impacted Files | Coverage Δ | |
---|---|---|
nafas/params.py | 100.00% <ø> (ø) |
|
nafas/functions.py | 94.78% <100.00%> (+0.25%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 77952c1...4e03f50. Read the comment docs.
@sadrasabouri Thanks for your effort 100
1. I think you convert `Prepair` instead of `Preparing`, please check it 2. I also suggest adding `start` and `end` sounds, what's your opinion?
Thanks for your review. new changes:
prepare.wav
--> preparing.wav
([/pruh·peh·ruhng/])start.wav
([/es-tart/]) addedwell_done.wav
([/vel-don/]) added
Reference Issues/PRs
43
Bellow changes will be applied after merge:
US English / Joanna
fromUS English / Justin
prepare.wav
sound added for prepare sectionflush=True
flag added to prints due to timing problems occurring when playing sound and printing simultaneously.