sepandhaghighi / nafas

🧘‍♂️ Breathing Gymnastics Application
MIT License
102 stars 6 forks source link

Prepare Section Sound #44

Closed sadrasabouri closed 3 years ago

sadrasabouri commented 3 years ago

Reference Issues/PRs

43

Bellow changes will be applied after merge:

codecov-io commented 3 years ago

Codecov Report

Merging #44 (4e03f50) into dev (77952c1) will increase coverage by 0.15%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #44      +/-   ##
==========================================
+ Coverage   95.84%   95.98%   +0.15%     
==========================================
  Files           2        2              
  Lines         168      174       +6     
  Branches       18       18              
==========================================
+ Hits          161      167       +6     
  Misses          4        4              
  Partials        3        3              
Impacted Files Coverage Δ
nafas/params.py 100.00% <ø> (ø)
nafas/functions.py 94.78% <100.00%> (+0.25%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 77952c1...4e03f50. Read the comment docs.

sadrasabouri commented 3 years ago

@sadrasabouri Thanks for your effort 100

1. I think you convert `Prepair` instead of `Preparing`, please check it

2. I also suggest adding `start` and `end` sounds, what's your opinion?

Thanks for your review. new changes: