search

sepandhaghighi / nafas

🧘‍♂️ Breathing Gymnastics Application
MIT License
132 stars 7 forks source link

Sound warning #71

Closed sadrasabouri closed 1 year ago

sadrasabouri commented 1 year ago

Reference Issues/PRs

49

What does this implement/fix? Explain your changes.

After this PR we will raise a warning after each failing trial for using playsound.

sadrasabouri commented 1 year ago

@sepandhaghighi Is there any way we can add tests for this new feature?

codecov-commenter commented 1 year ago

Codecov Report

Merging #71 (f0ad4bd) into dev (7308f7f) will increase coverage by 0.17%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev      #71      +/-   ##
==========================================
+ Coverage   96.47%   96.64%   +0.17%     
==========================================
  Files           2        2              
  Lines         198      208      +10     
  Branches       22       22              
==========================================
+ Hits          191      201      +10     
  Misses          4        4              
  Partials        3        3
Impacted Files Coverage Δ
nafas/functions.py 95.57% <100.00%> (+0.27%) :arrow_up:
nafas/params.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sadrasabouri commented 1 year ago

@sepandhaghighi Can you take a look at it again?