sepandhaghighi / nafas

🧘‍♂️ Breathing Gymnastics Application
MIT License
102 stars 6 forks source link

Feature/clean screen function #98

Closed oscarArismendi closed 4 weeks ago

oscarArismendi commented 4 weeks ago

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This pull request integrates the clear_screen function into the main module (__main__.py). Specifically, the function is called when the reset mode is activated. This enhancement ensures that the console screen is cleared appropriately, providing a cleaner interface during reset operations.

Any other comments?

For additional context, you can view the related GIF below:

oscarArismendi commented 4 weeks ago

I noticed the os.system usage in the code. If necessary, I can update it to use the subprocess module to address the security concern. Just let me know if you’d like me to make this change.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.54%. Comparing base (ebcfc97) to head (87c484b). Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
nafas/functions.py 60.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #98 +/- ## ========================================== - Coverage 97.47% 96.54% -0.92% ========================================== Files 2 2 Lines 197 202 +5 Branches 22 23 +1 ========================================== + Hits 192 195 +3 - Misses 4 5 +1 - Partials 1 2 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sepandhaghighi commented 4 weeks ago

@oscarArismendi Thanks for your contribution 🚀