search

sepandhaghighi / pycm

Multi-class confusion matrix library in Python
http://pycm.io
MIT License
1.45k stars 124 forks source link

fix for issue #430 decimal #431

Closed sheetcoder closed 2 years ago

sheetcoder commented 2 years ago

Reference Issues/PRs

https://github.com/sepandhaghighi/pycm/issues/430

What does this implement/fix? Explain your changes.

This will help to control the decimal points in the output screen. It locally rounds up the dictionary values when print_normalized_matrix method is called

Any other comments?

Although it passes the test. My own recommendation would be to round the numbers at the source. I tried to round up the figures at normalized_table_cal method but it was causing some unknown issue. So I didn't proceed that way and found this temp fix.

alirezazolanvari commented 2 years ago

Hi @sheetcoder,

I appreciate your efforts and apologize for the late response. We've reviewed this PR carefully and, as you mentioned, we think that there is a more efficient way for it. I'm closing this PR and we'll fix it at the source soon.