Closed sepandhaghighi closed 2 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.44%. Comparing base (
23b14c7
) to head (8748647
). Report is 1 commits behind head on dev.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM, Just a tiny point. Why did you remove
.
from the end of all sentences? If it's for consistency, I prefer to have.
at the end of sentences. If you think this comment is not applicable, simply merge it. The rest is OK.
Just for consistency. Fixed in https://github.com/sepandhaghighi/samila/pull/224/commits/088e9593f60955d6c4355787efd0c50ff20c5424
LGTM, Just a tiny point. Why did you remove
.
from the end of all sentences? If it's for consistency, I prefer to have.
at the end of sentences. If you think this comment is not applicable, simply merge it. The rest is OK.Just for consistency. Fixed in 088e959
Some sentences starting with ℹ️ have .
and some don't. Please make them consistent too.
LGTM, Just a tiny point. Why did you remove
.
from the end of all sentences? If it's for consistency, I prefer to have.
at the end of sentences. If you think this comment is not applicable, simply merge it. The rest is OK.Just for consistency. Fixed in 088e959
Some sentences starting with ℹ️ have
.
and some don't. Please make them consistent too.
Fixed in https://github.com/sepandhaghighi/samila/pull/224/commits/8748647fd27b5efbf664580181e9c1a4d1a78dcf
Reference Issues/PRs
What does this implement/fix? Explain your changes.
demo.ipynb
updatedAny other comments?