sepandhaghighi / samila

A Generative Art Generator
https://www.samila.site
MIT License
1.1k stars 79 forks source link

`demo.ipynb` updated #224

Closed sepandhaghighi closed 2 months ago

sepandhaghighi commented 2 months ago

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.44%. Comparing base (23b14c7) to head (8748647). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #224 +/- ## ======================================= Coverage 99.44% 99.44% ======================================= Files 4 4 Lines 709 709 Branches 111 111 ======================================= Hits 705 705 Misses 2 2 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sepandhaghighi commented 2 months ago

LGTM, Just a tiny point. Why did you remove . from the end of all sentences? If it's for consistency, I prefer to have . at the end of sentences. If you think this comment is not applicable, simply merge it. The rest is OK.

Just for consistency. Fixed in https://github.com/sepandhaghighi/samila/pull/224/commits/088e9593f60955d6c4355787efd0c50ff20c5424

sadrasabouri commented 2 months ago

LGTM, Just a tiny point. Why did you remove . from the end of all sentences? If it's for consistency, I prefer to have . at the end of sentences. If you think this comment is not applicable, simply merge it. The rest is OK.

Just for consistency. Fixed in 088e959

Some sentences starting with ℹ️ have . and some don't. Please make them consistent too.

sepandhaghighi commented 2 months ago

LGTM, Just a tiny point. Why did you remove . from the end of all sentences? If it's for consistency, I prefer to have . at the end of sentences. If you think this comment is not applicable, simply merge it. The rest is OK.

Just for consistency. Fixed in 088e959

Some sentences starting with ℹ️ have . and some don't. Please make them consistent too.

Fixed in https://github.com/sepandhaghighi/samila/pull/224/commits/8748647fd27b5efbf664580181e9c1a4d1a78dcf