search

sephii / taxi

Taxi is a CLI to time tracking backends
https://taxi-timesheets.readthedocs.io/
Do What The F*ck You Want To Public License
41 stars 15 forks source link

Warning display could be improve #127

Closed jeanmonod closed 4 years ago

jeanmonod commented 4 years ago

When I commit my timesheets, sometime I got a warning message. Here is an example:

image

It's not clear at all if the warning belong to the _internal or the fco_co activity. Can we improve that?

sephii commented 4 years ago

I agree with you, and I already had the exact same problem. ^^ Do you have any suggestion on how to improve this? Putting the line in yellow is not enough because you might have 2 entries with a warning that follow each other. Maybe adding some detail to the message like "There's an issue with the entry below: The project budget is exceeded. Maybe check with your PO"?

jeanmonod commented 4 years ago

A first step would be to put the warning after the entry. Maybe with indentation and a small ↳ ? Like:

_internal     0.25      Tests
   ↳ The project budget is exceeded
_internal     0.25      Tests
_internal     0.25      Tests
sephii commented 4 years ago

Fix will be released in the next taxi-zebra version.