search

sephiroth74 / ImageViewZoom

Android ImageView widget with zoom and pan capabilities
Other
1.9k stars 532 forks source link

add *FIT_HEIGHT* and *FIT_WIDTH* DisplayTypes #97

Closed sumit-anantwar closed 7 years ago

sumit-anantwar commented 7 years ago

We are using this library in our production code and we need the below DisplayTypes. And we believe that adding this functionality will surely add value to an already amazing library.

FIT_HEIGHT : The image fits such that the Image height matches the device height. Generally useful in portrait orientation. FIT_WIDTH : The image fits such that the Image width matches the device width. Generally useful in landscape orientation.

P.S. : We have also updated the gradle files and have made sure that the builds pass on Travis.

sumit-anantwar commented 7 years ago

Hi, because we need this functionality in our production code, we would be really grateful if you could review and accept this pull request.

sumit-anantwar commented 7 years ago

Thanks a lot! Do please let us know when the updates would be published on JCenter

sephiroth74 commented 7 years ago

I’ve just uploaded the snapshot version. Let me know if it’s ok, then I’ll publish the release. https://oss.sonatype.org/content/repositories/snapshots/it/sephiroth/android/library/imagezoom/imagezoom/2.3.0-SNAPSHOT/

- Alessandro Crugnola Adobe System Inc Photoshop Android Engineering Lead

100-104 Fifth Ave. New York, NY 10011

From: Sumit Anantwar notifications@github.com Reply-To: sephiroth74/ImageViewZoom reply@reply.github.com Date: Wednesday, June 28, 2017 at 2:26 PM To: sephiroth74/ImageViewZoom ImageViewZoom@noreply.github.com Cc: Alessandro Crugnola alessandro.crugnola@gmail.com, State change state_change@noreply.github.com Subject: Re: [sephiroth74/ImageViewZoom] add FIT_HEIGHT and FIT_WIDTH DisplayTypes (#97)

Thanks a lot! Do please let us know when the updates would be published on JCenter

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/sephiroth74/ImageViewZoom/pull/97#issuecomment-311746402, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAySMp2U5ItZOkTQ4U4GrRHHmORmmrPuks5sIprwgaJpZM4OG-ZG.

sumit-anantwar commented 7 years ago

Tested, it works perfectly! Appreciate the quick response. Thanks again.