sephynox / xrpl-rust

A 100% Rust library to interact with the XRPL. XRPL Grant Winner
https://crates.io/crates/xrpl-rust
ISC License
16 stars 8 forks source link

Ledger object models #57

Closed LimpidCrypto closed 1 year ago

LimpidCrypto commented 1 year ago

High Level Overview of Change

Ledger object models

Adds ledger object models including the AMM object model.

Models in general

It is also an attempt to implement a general order for fields (models/mod.rs):

//! Order of models:
//! 1. Type of model
//! 2. Required common fields in alphabetical order
//! 3. Required specific fields in alphabetical order
//! 4. Optional common fields in alphabetical order
//! 5. Optional specific fields in alphabetical order

If agreed on the order:

serde_with_tag

Moved the Helper to fn serialize and fn deserialize to avoid defining it multiple times in a file.

Context of Change

27

Type of Change

Test Plan

Future Tasks

Keep an eye on the XRPFees amendment. It could change how some fields are typed and/or named.

LimpidCrypto commented 1 year ago

Alright somehow it put all commits of develop branch in here. This is impossible to review. I will fix it and open a new PR