sephynox / xrpl-rust

A 100% Rust library to interact with the XRPL. XRPL Grant Winner
https://crates.io/crates/xrpl-rust
ISC License
16 stars 8 forks source link

Add transaction models #6

Closed LimpidCrypto closed 2 years ago

LimpidCrypto commented 2 years ago

High Level Overview of Change

Context of Change

To make it as easy as possible to define a transaction there should be transaction objects. Because rust does not support inheritance of two structs each transaction contain the common fields, making the TransactionFields object unnecessary. Doing so makes it easier for the user to define the transaction (define one object instead of two). This PR also includes transaction flags.

Type of Change

Test Plan

TODO

Remarks

sephynox commented 2 years ago

Looks good! However, the src/models/transactions.rs file has implementations, methods, etc. and should have accompanying unit tests for each method. Tests should always be present before any merge otherwise they end up never being added later.