sephynox / xrpl-rust

A 100% Rust library to interact with the XRPL. XRPL Grant Winner
https://crates.io/crates/xrpl-rust
ISC License
20 stars 8 forks source link

DO NOT MERGE - Async networking #67

Closed LimpidCrypto closed 1 year ago

LimpidCrypto commented 1 year ago

High Level Overview of Change

Adds async networking abilities:

Due to the milestones complexity, a new crate em-as-net will be created. For a high level overview of the state of em-as-net see this issue:

Important to notice: At the time of writing the crate is still missing TlsConnection to establish safe connections.

The PR also contains smaller improvements like making ˋnewˋ methods public and importing the ˋToStringˋ trait in the ˋErr!ˋ macro instead of importing it in every file that uses the macro.

TODO

Type of Change

Test Plan

A code sample was added to tests/common.rs

LimpidCrypto commented 1 year ago

I still have an issue with the github workflow, claiming that it can't find xrpl::asynch::clients and rand::rngs::ThreadRng:

error[E0432]: unresolved import `rand::rngs::ThreadRng`
 --> tests/common/mod.rs:4:5
  |
4 | use rand::rngs::ThreadRng;
  |     ^^^^^^^^^^^^^^^^^^^^^ no `ThreadRng` in `rngs`
error[E0432]: unresolved import `xrpl::asynch::clients`
 --> tests/common/mod.rs:6:19
  |
6 | use xrpl::asynch::clients::{
  |                   ^^^^^^^ could not find `clients` in `asynch`
error[E0432]: unresolved import `xrpl::asynch::clients`
 --> tests/integration/clients/mod.rs:6:23
  |
6 |     use xrpl::asynch::clients::{ReadResult, WebsocketClose, WebsocketIo};
  |                       ^^^^^^^ could not find `clients` in `asynch`
LimpidCrypto commented 1 year ago

Closed in favor of #70