This PR makes use of the XRPL CommonFields in the models making it easier to work with them.
It also adds some smaller features like:
LedgerObject trait
Context of Change
As I was working on #71 the current models made it really hard to get model values (mostly from common fields). I had to write workarounds to get/set values of a model making it really inconvenient to work with them. This PR add CommonFields introducing a way easier way to work with the models.
Type of Change
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Test Plan
The tests already exist.
TODO
[x] fix tests (mostly json string keys in false order)
[x] recheck field order and if all common_field gets #[serde(flatten)]
High Level Overview of Change
This PR makes use of the XRPL
CommonFieldsin the models making it easier to work with them. It also adds some smaller features like:LedgerObjecttraitContext of Change
As I was working on #71 the current models made it really hard to get model values (mostly from common fields). I had to write workarounds to get/set values of a model making it really inconvenient to work with them. This PR add
CommonFieldsintroducing a way easier way to work with the models.Type of Change
Test Plan
The tests already exist.
TODO
common_fieldgets#[serde(flatten)]pubcargo fixetc.