search

sepinf-inc / IPED

IPED Digital Forensic Tool. It is an open source software that can be used to process and analyze digital evidence, often seized at crime scenes by law enforcement or in a corporate investigation by private examiners.
Other
924 stars 217 forks source link

Discord Parser showing wrong attachment file #1898

Closed felipecampanini closed 11 months ago

felipecampanini commented 11 months ago

If there are two files with the same name, the parser could show the wrong file.

The bug was fixed in commit 902326d.

Now the file is fetched based on the name and id contained in the URL.

lfcnassif commented 11 months ago

Hi @felipecampanini, thanks for reporting. Does this affect any released version? Or just PR #1859?

felipecampanini commented 11 months ago

Hi @lfcnassif, this affects all previously released versions.

lfcnassif commented 11 months ago

Fine! So, if we release a 4.1.5 version, I'll cherry pick the fix, thank you!

lfcnassif commented 11 months ago

The bug was fixed in commit 902326d.

Hi @felipecampanini. That commit seems to me to allow a possible ArrayIndexOutOfBoundsException, possibly when handling corrupted data. Could you complement it to check for the array length returned by the split call?

lfcnassif commented 11 months ago

I had some spare time and did it. Fixed on master by commits c5fae0d and d71c6c8.

felipecampanini commented 9 months ago

Sorry for the delay, thanks @lfcnassif