search

sepinf-inc / IPED

IPED Digital Forensic Tool. It is an open source software that can be used to process and analyze digital evidence, often seized at crime scenes by law enforcement or in a corporate investigation by private examiners.
Other
940 stars 218 forks source link

Whatsapp quote messages #1920

Closed gfd2020 closed 8 months ago

gfd2020 commented 11 months ago

Implementation of WhatsApp quote messages. Android Old DB - OK ( carved quotes fully implemented ) IPHONE - OK ( carved quotes NOT fully implemented ) Android New DB - OK ( carved quotes fully implemented )

gfd2020 commented 10 months ago

Seems very nice!

Good!

I'm almost done implementing it. Do you think we need the window title? (this one in bold). To give credit to the author (MIT license) do I include it in the source code or do I have to edit the license txt?

lfcnassif commented 10 months ago

Do you think we need the window title? (this one in bold).

If removing it decreases the dialog size, I think we can stay without it, otherwise I would put a generic title like "Message" or "Warning".

To give credit to the author (MIT license) do I include it in the source code or do I have to edit the license txt?

Yes, please keep the copyright into the source if you copy it into the project, list the library in ThirdParty.txt file and copy its MIT license to licenses folder.

PS: Another advantage of using a javascript solution instead of a callback into java code is less exposure to possible security issues.

gfd2020 commented 10 months ago

If removing it decreases the dialog size, I think we can stay without it, otherwise I would put a generic title like "Message" or "Warning".

I think that way is better: image

Yes, please keep the copyright into the source if you copy it into the project, list the library in ThirdParty.txt file and copy its MIT license to licenses folder.

Just copy link to the project page on javascript and css files. I can´t find the MIT file on source page...

gfd2020 commented 9 months ago

Hi @lfcnassif ,

Sorry to bother you. Were you able to redo the tests for this PR?

lfcnassif commented 9 months ago

I'm really sorry @gfd2020, not yet, other things took my attention... I promise you the next new feature I'll focus on will be this (bug fixes may take priority). But I'll be very busy in the next days and weeks, including this weekend. I'll try to return to this next week in the night...

gfd2020 commented 9 months ago

Hi @lfcnassif .

I see. Just take your time. No problem. I think removing bugs is more important. This PR will eventually be integrated at the right time.

lfcnassif commented 8 months ago

Hi @gfd2020. I'm merging this right now to avoid more merge conflicts with WA parser improvements @wladimirleite currently is working on. I detected just very minor differences between this and master and I think this is very very good as is. I'll try to redo my tests later in January to confirm if my findings are really an issue or not. Thank you very much for this great feature!

wladimirleite commented 8 months ago

Thanks @lfcnassif! After solving a couple of minor conflicts, I merged the master into the WA branch I am working on. This will avoid further conflicts.

@gfd2020, I just saw the generated HTML including the support to quote messages you implement, it looks really nice and will be very useful. Thank you!