sepinf-inc / IPED

IPED Digital Forensic Tool. It is an open source software that can be used to process and analyze digital evidence, often seized at crime scenes by law enforcement or in a corporate investigation by private examiners.
Other
949 stars 219 forks source link

Upgrade TwelveMonkeys to 3.10 #1966

Closed wladimirleite closed 11 months ago

wladimirleite commented 11 months ago

Recently a new version of TwelveMonkeys library was released: https://github.com/haraldk/TwelveMonkeys/releases/tag/twelvemonkeys-3.10.0 It includes fixes and enhancements for formats that we use its plugins (WEBP, PSD and TIFF).

Testing with a large set of images I have come to these conclusions (comparing thumb creation task):

So overall the new release is better, except for a critical issue that happened with 4 malformed (incomplete or corrupted) PSD images. Before (with version 3.9.4) "something" was rendered, but with the new version (3.10.0) it doesn't return from the ImageIO.read() function. For the ThumbTask there is a timeout that takes care of it, but it causes a strange (unresponsive viewer) behavior when opening these images in the analysis GUI. I will open an issue in the TwelveMonkeys project.

wladimirleite commented 11 months ago

An example of PSD that cause the issue with 3.10.0: corrupted-psd.zip

This is how its thumbnail was rendered with 3.9.4: image

wladimirleite commented 11 months ago

https://github.com/haraldk/TwelveMonkeys/issues/860

wladimirleite commented 11 months ago

The issue was fixed already. There should be a 3.10.1 bug fix release soon. When it is available, I will repeat the tests.

wladimirleite commented 11 months ago
  • WEBP (115,000): Rendering improved a lot for ~3,000 images. Before these images were not rendered at all, just a full white or black area, or rendered very poorly.

Just for the sake of completeness, an example of a WEBP that is rendered much better with the newer version (sample-webp.zip):

3.9.4 image

3.10.0 image

lfcnassif commented 11 months ago

Very nice!