search

sepinf-inc / IPED

IPED Digital Forensic Tool. It is an open source software that can be used to process and analyze digital evidence, often seized at crime scenes by law enforcement or in a corporate investigation by private examiners.
Other
886 stars 211 forks source link

Reset case finished flag only after basic checks (#2041) #2042

Closed wladimirleite closed 6 months ago

wladimirleite commented 6 months ago

Fix #2041.

lfcnassif commented 6 months ago

Thanks @wladimirleite. I took a look at this from my mobile and haven't tested, but I think the finished flag was also being cleared when removing an evidence from an existing case, and I think that wrong behavior continues after the proposed changes. Could you test?

The idea of clearing that flag is to warn users about an incomplete processing when using --append (or --restart) options.

wladimirleite commented 6 months ago

Sure! I will test removing an evidence.

wladimirleite commented 6 months ago

When removing an existing evidence, it was working fine already (the file was removed and later created again). The code modifications that I made didn't change this behavior.

lfcnassif commented 6 months ago

PS: Just saw the create finished file flag at the end of removeEvidence() method.