sepinf-inc / IPED

IPED Digital Forensic Tool. It is an open source software that can be used to process and analyze digital evidence, often seized at crime scenes by law enforcement or in a corporate investigation by private examiners.
Other
884 stars 209 forks source link

Update OCRParserTest to use Tesseract and ImageMagick current versions. #2122

Closed wladimirleite closed 3 months ago

wladimirleite commented 3 months ago

Just a minor detail I noticed while working on another issue.

wladimirleite commented 3 months ago

Not sure if versions should be hardcoded there, but for now I just updated to the versions used by the application.

lfcnassif commented 3 months ago

@wladimirleite I was already getting OCR parser tests failures on windows (testOCRParserPSD and testOCRParserSVG) before this PR and thought this change would fix them, but it didn't. Have you experienced failures on those tests using master?

wladimirleite commented 3 months ago

No, tests have been running fine here. I think @felipecampanini had issues with the two tests that you mentioned when he installed a new environment. Can't remember the cause/solution right now, but I will try to find out tomorrow.

wladimirleite commented 3 months ago

Are you using a new machine or reinstalled Eclipse?

wladimirleite commented 3 months ago

I think @felipecampanini had issues with the two tests that you mentioned when he installed a new environment. Can't remember the cause/solution right now, but I will try to find out tomorrow.

I found some direct messages about this. In his case the issue was solved setting the Eclipse JRE to a Liberica JDK 11. It was using JDK 17 (embedded in newer Eclipse versions). Not sure how this is related to the OCRParserTes error though...

lfcnassif commented 3 months ago

Are you using a new machine or reinstalled Eclipse?

I think I updated eclipse some months ago, not recently. An important detail is that all tests pass building with maven from command line, so seems related to the IDE indeed.

lfcnassif commented 3 months ago

I found some direct messages about this. In his case the issue was solved setting the Eclipse JRE to a Liberica JDK 11. It was using JDK 17 (embedded in newer Eclipse versions). Not sure how this is related to the OCRParserTes error though...

Changing to JDK 11 also worked here, thanks!