sepinf-inc / IPED

IPED Digital Forensic Tool. It is an open source software that can be used to process and analyze digital evidence, often seized at crime scenes by law enforcement or in a corporate investigation by private examiners.
Other
884 stars 209 forks source link

Use a more controlled method for getting a ImageInputStream from an Item (#2033) #2123

Closed wladimirleite closed 3 months ago

wladimirleite commented 3 months ago

Closes #2033.

I ran a large comparison test processing 2 E01 (each from a 500 GB HDD), 2 UFDR (one Android with ~30GB and one iOS with ~60GB), and a folder with ~1000 images of many different formats. All common processing options were enabled, except OCR. Total processing time was slightly reduced (6h23min with master and 6h12min with this PR). Time spent in ImageThumbTask was also slightly better (5% reduction). Thumbs generated were almost the same (3 generated now but not before, and 7 in the opposite situation, out of 1.2M images). All these images with no thumbs in one of the cases were carved, with no useful information. ~30 thumbs were slightly different (visually), but better in the newer version.

In short, the results were similar, maybe a small performance gain, but now the out of memory error caused by the large tiff is gone.

lfcnassif commented 3 months ago

Thank you @wladimirleite!