#2077 fix - Githubissues

sepinf-inc / IPED

IPED Digital Forensic Tool. It is an open source software that can be used to process and analyze digital evidence, often seized at crime scenes by law enforcement or in a corporate investigation by private examiners.

Other

884 stars 209 forks source link

#2077 fix #2151

Closed lfcnassif closed 3 months ago

lfcnassif commented 3 months ago

Fix #2077 by using a new CSV commit control file to avoid corrupting FileListing.csv. Also skips already committed items to avoid huge CSV files when resuming multiple times.

lfcnassif commented 3 months ago

@marcus6n could you please also test this? Steps:

Go to conf/IndexTaskConfig.txt and decrease commitIntervalSeconds to something like 15s ou 30s;
Process a whole evidence till the end without interrupting it;
Process the same evidence to another output folder, but now interrupting it multiple times at different points and resuming processing with --continue option;
Compare the FileList.csv files of both cases, they should have the exact same size, although the rows can appear in a different order, that's expected.
Test the --restart option with similar steps like above

marcus6n commented 3 months ago

@lfcnassif Yes, I'll test this.

marcus6n commented 3 months ago

@lfcnassif I tested it here and the FileList.csv remained the same size, even when pausing and using the --continue option when processing the case and the --restart option, they remained the same size.

PS: I used an interval of 17s in commitIntervalSeconds

lfcnassif commented 3 months ago

Thank you for testing @marcus6n, I'll merge this soon.

lfcnassif commented 3 months ago

In my last tests I got CSVs with different sizes, but also different number of items in the cases, which is related to #2148, not to this PR that seems fine.