search

sepinf-inc / IPED

IPED Digital Forensic Tool. It is an open source software that can be used to process and analyze digital evidence, often seized at crime scenes by law enforcement or in a corporate investigation by private examiners.
Other
884 stars 209 forks source link

Link case files to torrents and torrents to resume.dat (#2185) and identify settings.dat (#2193) #2187

Closed wladimirleite closed 1 month ago

wladimirleite commented 2 months ago

Closes #2185. Closes #2193.

wladimirleite commented 2 months ago

Just finished the changes I had in mind. I asked the user that is working on a real case in which this PR should be useful to test and I am leaving this as draft until I get his feedback.

lfcnassif commented 2 months ago

Thank you @wladimirleite!

wladimirleite commented 2 months ago

The user reprocessed his case with this branch, and it worked as expected.

wladimirleite commented 2 months ago

I added changes to #2193 in this same PR. I had to force push this branch to fix two commits with incorrect issue number. This should be ready for review now.

patrickdalla commented 2 months ago

Hi @wladimirleite, @lfcnassif asked me to review this. Could you share your samples?

wladimirleite commented 2 months ago

Hi @patrickdalla! Sure, I will send you some samples when I am back at my desk.

wladimirleite commented 1 month ago

Thanks @patrickdalla! I will run a last test using a cases with larger videos (that I didn't send to you as there are ~400 GB of data).

wladimirleite commented 1 month ago

I only make a last suggestion of putting the name (or path) of the real corresponding item found, as it can be completely different from the name inside the torrent file and a little confusing for the end user to understand the correspondence. But is just a suggestion.

I added the path of the item found in the case as a new column and made minor formatting changes, to ensure a minimal width for the columns and use a smaller font for confirmed pieces indexes and offset (to save some space and to highlight the 'Yes' in the 'File Found in the Case' column). image

wladimirleite commented 1 month ago

@lfcnassif, I believe @patrickdalla finished his review. I just made a couple of minor changes and included French strings introduced in this PR with [TBT]'s. I don't plan to make any more changes in this PR.

lfcnassif commented 1 month ago

@lfcnassif, I believe @patrickdalla finished his review.

Sorry @wladimirleite, I forgot this was approved by him. I'll merge this shortly.

and included French strings introduced in this PR with [TBT]'s.

Thank you! I was going to do that.