search

sepluginloader / PluginLoader

A tool to load plugins for Space Engineers automatically.
https://sepluginloader.github.io/
MIT License
46 stars 12 forks source link

Plugins Menu Overhaul and Stats Preparation #14

Closed WesternGamer closed 2 years ago

WesternGamer commented 2 years ago

Plugins menu is now completely overhauled. I added code in PluginData in preparation for the stats code as it would be easier to implement the system in PluginData than in the menu class. For more info about that code, go to region IMPORTANT starting at line 77 in PluginData.cs.

Have a good day!

WesternGamer commented 2 years ago

If you need more info, please communicate here as I am available here earlier than on discord. Thanks!

austinvaness commented 2 years ago

Why were the checkboxes in the list removed? Clicking each one individually doesnt seem like a good replacement

WesternGamer commented 2 years ago

It is because there was an bug where the checkboxes in the list would not select in the correct place and I did not feel like fixing that issue because I thought that the issue is in the list control. There is most likely a way to fix the checkbox issue and leave the checkboxes in the list but it is just a few extra seconds to select each one as you would usually don't try to select all plugins in the list. You can revert that change if you feel like that you can fix the checkbox issue.

On Wed, Dec 8, 2021, 11:37 PM austinvaness @.***> wrote:

Why were the checkboxes in the list removed? Clicking each one individually doesnt seem like a good replacement

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/austinvaness/PluginLoader/pull/14#issuecomment-989504289, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATD66AVNOCYGJU6H2LRTH5LUQAW7DANCNFSM5JVJJHZQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

WesternGamer commented 2 years ago

Looking at your code changes, thanks for finding a more proper solution in ChangePluginEnableStatus. I did not know you can change the cell value like that as the StringBuilder text field is read only.

WesternGamer commented 2 years ago

Please rereview to PR as some changes has been made.