search

sepluginloader / PluginLoader

A tool to load plugins for Space Engineers automatically.
https://sepluginloader.github.io/
MIT License
46 stars 11 forks source link

Issue with workshop links in plugin descriptions #63

Open emmawilby opened 3 months ago

emmawilby commented 3 months ago

Thanks for working on this! I've played this game for years but didn't realize how many great plugins there were.

I noticed an issue when clicking on the workshop link included in the description for the Blueprint API plugin: it opens the workshop page in the steam overlay correctly but when the overlay is closed with shift tab or escape it immediately re-opens. It's possible to back out by mashing the escape key to go back to the plugin list so not a critical issue.

I'm running on linux (Gnome/Wayland on Debian stable / a non-flatpak steam installation), with the latest proton GE if it's relevant. This issue occurred before I had enabled any plugins.

austinvaness commented 3 months ago

I'm not sure how to fix this, I am literally just calling keen's code:

public override void Show()
{
    MyGuiSandbox.OpenUrl("https://steamcommunity.com/workshop/filedetails/?id=" + Id, UrlOpenMode.SteamOrExternalWithConfirm);
}

I guess I would have to find the issue in the base game and patch it

emmawilby commented 3 months ago

Just took another look, it seems like the code above works without issue (when you click the more details button on a mod). I'm talking about when there's a text link in the description of a plugin (like with the Blueprints API), which seems to be this line of code:

https://github.com/sepluginloader/PluginLoader/blob/67ecaeed26c284a9d9bdbee8e89ef2453c86a8be/PluginLoader/GUI/PluginDetailMenu.cs#L83

I'm not particularly familiar with C# or space engineers apis at all, but I wonder if descriptionText has a default onlinkedclicked that's causing something to double-fire. Anyway, it probably won't affect too many people if it's not an easy fix, just wanted to make sure you were aware.