septadev / GTFS

21 stars 4 forks source link

Remove spaces in column definition #11

Closed fulldecent closed 3 years ago

fulldecent commented 7 years ago

Google GTFS file format specifies

Remove any extra spaces between fields or field names. Many parsers consider the spaces to be part of the value, which may cause errors.

SEPTA rail feed violates this specification, for example, in calendar.txt:

service_id, monday, tuesday, wednesday, thursday, friday, saturday, sunday, start_date, end_date

Instead the correct format should be:

service_id,monday,tuesday,wednesday,thursday,friday,saturday,sunday,start_date,end_date

Please note that the default CVS import from SQLite will misinterpret SEPTA's data as currently published. This is what happens:

sqlite> SELECT * FROM calendar;
service_id," monday"," tuesday"," wednesday"," thursday"," friday"," saturday"," sunday"," start_date"," end_date"

Currently, this is the import script I am using:

https://github.com/fulldecent/septa-regionalrail-otp/blob/master/website/databases/sqliteGTFSImport.txt

fulldecent commented 7 years ago

I confirm this is still broken in the new release https://github.com/septadev/GTFS/tree/v20170423.1

fulldecent commented 6 years ago

Ping @septadev / confirming this is still broken in the latest version.

Please respond if you recognize this as a valid issue and if a fix is desirable to the project.

Wendowski commented 3 years ago

This is fixed in the recent releases of GTFS.

fulldecent commented 3 years ago

Much appreciated, thank you