septract / starling-tool

An automatic verifier for concurrent algorithms.
MIT License
7 stars 4 forks source link

Simplify array traversals. #108

Closed MattWindsor91 closed 7 years ago

MattWindsor91 commented 7 years ago

Makes tliftToArraySrc not return a new eltype and length, and thus simplifies assemble by a lot.

This does not do any deep checking of whether the eltype makes sense, but to be fair the rest of Starling doesn't either (yet).

This is an fix for one of @septract's concerns on #99 that didn't quite make it to that PRQ. It turns out this was indeed a 5 minute fix, just I couldn't see the wood for the trees when I tried it the first time.

MattWindsor91 commented 7 years ago

@BenSimner can you look at this one? It's fairly small and inconsequential

septract commented 7 years ago

Looks good aside from minor comments. Just merge when you've fixed them.