seq-lang / seq

A high-performance, Pythonic language for bioinformatics
https://seq-lang.org
Apache License 2.0
698 stars 50 forks source link

file_obj.read function requires number of bytes to be read as mandatory argument #257

Open Prakash2403 opened 2 years ago

Prakash2403 commented 2 years ago

Example:

Executing

# This raises error
with open('sample.txt') as f:
    data = f.read()

raises an error saying error: missing argument 'sz'. However, when the number of bytes to be read is passed explicitly, it works as expected

# This returns first 100 bytes
with open('sample.txt') as f:
    data = f.read(100)

Ideal Behaviour

If nothing is passed, the whole file should be read and returned.

Possible fix Assumption: internal/file.seq handles all file operations (read in this case)

Need to make sz and Optional parameter here. And if sz is None, then set sz to the file size.