search

seqan / hibf

HIBF and IBF
https://docs.seqan.de/hibf
Other
4 stars 2 forks source link

[TEST] Reactivate rearrange_user_bins test. #190

Closed smehringer closed 9 months ago

smehringer commented 9 months ago

Fixes #130

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hibf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 0:18am
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a46510d) 99.94% compared to head (359c0b4) 99.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #190 +/- ## ======================================= Coverage 99.94% 99.94% ======================================= Files 46 46 Lines 1835 1835 ======================================= Hits 1834 1834 Misses 1 1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

smehringer commented 9 months ago

@eseiler hm it seems that clang isn't happy with the change. Seems like for clang, the distance are not 0. Could you take a look?

eseiler commented 9 months ago

The coverage also didn't change. So we still are missing that one line :) BTW, are the sketches all supposed to be the same?

Edit: The missed line is somewhere else, so we hit the one line at some point. I'll check clang