search

seqan / hibf

HIBF and IBF
https://docs.seqan.de/hibf
Other
4 stars 2 forks source link

[MISC] Compute layout also takes positions. #210

Closed smehringer closed 2 months ago

smehringer commented 2 months ago

Next step to make the hibf lib compatible with the incoming partitioned HIBF and Fast Layouted HIBF.

In that case, we do not always layout ALL user bins [0,n-1] but only part of them (e.g. only the first 10 for the first partition). Therefore, a layout needs to be able to be computed given an extra position vector, s.t. auxiliary information, e.g. sketches, remain untouched but I can pick whatever I need.

Fot the original layout, we just need to pass the original positions [0,n-1].

Also not that the data_store of the layout already kept positions anyway to be able to sort user bins without modifying sketches and kmer_counts. I now simply made the positions accessible (set-able?) from the outside.

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
hibf ✅ Ready (Inspect) Visit Preview Jul 11, 2024 9:32am
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.67%. Comparing base (42e493f) to head (53c9cff).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #210 +/- ## ======================================= Coverage 99.67% 99.67% ======================================= Files 46 47 +1 Lines 1833 1845 +12 Branches 5 5 ======================================= + Hits 1827 1839 +12 Misses 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.