search

seqan / hibf

HIBF and IBF
https://docs.seqan.de/hibf
Other
4 stars 2 forks source link

[MISC] Use uint64_t::max() for merged bins #222

Closed eseiler closed 1 week ago

eseiler commented 2 weeks ago

Luckily, -1 and std::numeric_limits<uint64_t>::max() have the same binary representation, so no breakage for serialisation. https://godbolt.org/z/756arGfMK

This also solves the problem that number_of_user_bins is unsigned, but the internal representation for the user bin IDs uses signed integers. The previous maximum number_of_user_bins was actually std::numeric_limits<int64_t>::max().

seqan-actions commented 2 weeks ago

Documentation preview available at https://docs.seqan.de/preview/seqan/hibf/222

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.68%. Comparing base (0cab5ec) to head (4ca32eb). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #222 +/- ## ======================================= Coverage 99.68% 99.68% ======================================= Files 49 49 Lines 1912 1914 +2 Branches 5 5 ======================================= + Hits 1906 1908 +2 Misses 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.