seqan / hibf

HIBF and IBF
https://docs.seqan.de/hibf
Other
4 stars 2 forks source link

[MISC] Pass mutable to hibf ctor and avoid config copy #66

Closed smehringer closed 1 year ago

smehringer commented 1 year ago

I think it is very surprising if something in the configuration changes although you have passed a const &. So I moved the checking and default setting to the very top and removed the copy from layout::execute.

I added a little bit documentation.

Supersedes #34

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hibf ❌ Failed (Inspect) Sep 4, 2023 3:17pm
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (b2c50dc) 93.79% compared to head (73c4f5b) 93.80%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #66 +/- ## ======================================= Coverage 93.79% 93.80% ======================================= Files 39 39 Lines 1353 1355 +2 ======================================= + Hits 1269 1271 +2 Misses 84 84 ``` | [Files Changed](https://app.codecov.io/gh/seqan/Hierarchical_Interleaved_Bloomfilter/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan) | Coverage Δ | | |---|---|---| | [include/hibf/config.hpp](https://app.codecov.io/gh/seqan/Hierarchical_Interleaved_Bloomfilter/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan#diff-aW5jbHVkZS9oaWJmL2NvbmZpZy5ocHA=) | `100.00% <ø> (ø)` | | | [...ude/hibf/hierarchical\_interleaved\_bloom\_filter.hpp](https://app.codecov.io/gh/seqan/Hierarchical_Interleaved_Bloomfilter/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan#diff-aW5jbHVkZS9oaWJmL2hpZXJhcmNoaWNhbF9pbnRlcmxlYXZlZF9ibG9vbV9maWx0ZXIuaHBw) | `89.65% <ø> (ø)` | | | [src/config.cpp](https://app.codecov.io/gh/seqan/Hierarchical_Interleaved_Bloomfilter/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan#diff-c3JjL2NvbmZpZy5jcHA=) | `82.85% <50.00%> (-17.15%)` | :arrow_down: | | [src/hierarchical\_interleaved\_bloom\_filter.cpp](https://app.codecov.io/gh/seqan/Hierarchical_Interleaved_Bloomfilter/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan#diff-c3JjL2hpZXJhcmNoaWNhbF9pbnRlcmxlYXZlZF9ibG9vbV9maWx0ZXIuY3Bw) | `78.88% <100.00%> (+0.23%)` | :arrow_up: | | [src/layout/execute.cpp](https://app.codecov.io/gh/seqan/Hierarchical_Interleaved_Bloomfilter/pull/66?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=seqan#diff-c3JjL2xheW91dC9leGVjdXRlLmNwcA==) | `100.00% <100.00%> (+37.50%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.